Admin overview config overviews #6482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added mermaid graphic and content formatting testing
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
knative-prow
bot
added
the
size/M
knative-prow
bot
added
the
do-not-merge/work-in-progress
Formatting testing
Trying a "blog" approach....
Minor edits
Link fixes
Minor edits
Co-authored-by: Evan Anderson <[email protected]>
knative-prow
bot
added
size/L
Added Eventing config summaries
Put all config overviews in tables
Section title tweaks
Formatting edits
Organized sections
Formatting test
Removed temporary test
Section organization
Title shortening
Alphabetized rows in config summary tables
Link text edits in tables first columns
Minor edit to rebuild
Reviewer updates and mermaid edits
mermaid tweaks
style try
hopeful mermaid fix
knative-prow
bot
removed
the
do-not-merge/work-in-progress
Contributor
Author
|
Ready for merge approval. |
Member
evankanderson
left a comment
evankanderson
left a comment
There was a problem hiding this comment.
This should really-actually be the last set of comments. It's looking very close, and I only noticed these items on a close reading of the preview page.
Comment on lines
40
to
43
| Serving --> net-impl["Implements"] | ||
| net-impl --> net-istio & net-contour & net-gateway-api | ||
| Eventing --> event-impl["Implements"] | ||
| event-impl --> event-kafka & event-rabbitmq & event-nats |
Member
There was a problem hiding this comment.
These arrows point the wrong way for "Implements" -- maybe "Provided by" or "Implemented with"?
| | [Default configurations](../serving/configuration/config-defaults.md) | `config-defaults` | Default resource values such as performance, hardware, and storage settings. | | ||
| | [Deployment resources](../serving/configuration/deployment.md) | `config-deployment` | Kubernetes deployment resources that back Knative services. | | ||
| | [Domain names](../serving/using-a-custom-domain.md) | `config-domain` | Configure and publish domains. | | ||
| | [High-availability](../serving/config-ha.md) | NA | Configure ensure that APIs stay operational if a disruption occurs. | |
Member
There was a problem hiding this comment.
The "High Availability" and "Namespace exclusion" topics apply to both Serving and Eventing. I don't know if you want to repeat them, or pull them out into their own section.
Co-authored-by: Evan Anderson <[email protected]>
Co-authored-by: Evan Anderson <[email protected]>
Co-authored-by: Evan Anderson <[email protected]>
Co-authored-by: Evan Anderson <[email protected]>
Co-authored-by: Evan Anderson <[email protected]>
Co-authored-by: Evan Anderson <[email protected]>
mermaid directional tweaks
mermaid test
mermaid test
mermaid testing
mermaid testing
mermaid testing
mermaid testing
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evankanderson, iRaindrop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overview of configuration tasks should parallell the Navigation.
Proposed Changes